Add comprehensive integration tests covering:
- TestIntegration_PathWithSlashes: nested paths work as distinct rooms
- TestIntegration_QueryStringIgnored: query strings stripped, same room
- TestIntegration_DefaultRoom: bare root path broadcast works
- TestIntegration_ClientDisconnectFromRoom: remaining clients communicate
- TestIntegration_ConcurrentRoomOperations: no races with rapid connect/disconnect
All tests pass with -race flag.
🤖 Assisted by the code-assist SOP
Add dedicated integration tests verifying message isolation between rooms:
- TestIntegration_SameRoomBroadcast: two clients in /chat both receive
broadcast messages
- TestIntegration_CrossRoomIsolation: client in /room-a does not leak
messages to client in /room-b (verified via read deadline timeout)
- TestIntegration_MultipleRoomsSimultaneous: 3 rooms with 2 clients
each, messages stay within their room
- TestIntegration_RoomCleanup: verifies RoomCount() increases on
connect and decreases (room removed) on last client disconnect
- TestIntegration_RoomCleanup_MultipleClients: room persists while
any client remains connected
- TestIntegration_RoomCleanup_ConcurrentDisconnects: 5 rooms cleaned
up concurrently without races
Also introduces dialWSPath(t, server, path) helper for tests that
specify WebSocket paths directly with a leading slash.
All tests pass with -race flag.
🤖 Assisted by the code-assist SOP
Refactor the stop case in Hub.Run() to iterate h.rooms directly
instead of h.connRoom. For each room, iterate all connections and
send CloseGoingAway frame before closing. After the loop, reset both
maps (h.rooms, h.connRoom) in one shot rather than deleting entries
incrementally. This is cleaner and avoids modifying a map during
iteration.
Add TestIntegration_GracefulShutdownMultiRoom to verify clients in
separate rooms all receive close frames during shutdown.
🤖 Assisted by the code-assist SOP
Change HandleWebSocket to use r.URL.Path as the room identifier instead
of r.URL.Query().Get("room"). This enables clean URL-based room routing
(e.g., ws://host/room-a) without query strings.
Update test helpers (dialTestHub, dialWSWithRoom) to connect via path
segments and fix direct broadcast channel tests to use path-style room
names (with leading slash).
All existing tests pass — clients connecting to / get the default room.
🤖 Assisted by the code-assist SOP
Add tests verifying that the broadcast case in Hub.Run() correctly
sends messages only to clients in the same room as the sender:
- TestIntegration_RoomIsolation_MessagesOnlyGoToSameRoom: verifies
messages from room-a are received by room-a clients and NOT by
room-b clients
- TestIntegration_RoomIsolation_MultipleRoomsIndependent: verifies
two rooms operate independently with no message leakage
- TestIntegration_BroadcastToEmptyRoom: verifies graceful handling
when broadcasting to a non-existent room (no panic, hub remains
functional)
- TestBroadcastRoomIsolation: unit-level room isolation test using
the broadcast channel directly
Also adds dialWSWithRoom helper for room-aware WebSocket connections
in integration tests.
🤖 Assisted by the code-assist SOP
- Change ConnectedClients metrics from Set() to Inc()/Dec() pattern
for cleaner, atomic metric updates in register/unregister/broadcast
- Add room info to unregister and broadcast-cleanup log messages
- Handle unregistered connections gracefully (close without panic)
- Capture count inside lock for accurate log output
Tests added:
- TestRegisterClient: verifies ClientCount/RoomCount after connect
- TestUnregisterClient: verifies cleanup after disconnect
- TestRegisterMultipleRooms: verifies multi-room state tracking
- TestUnregisterCleansUpEmptyRoom: verifies empty room deletion
- TestUnregisterUnknownConnNoPanic: verifies no panic on unknown conn
All tests pass including race detector.
🤖 Assisted by the code-assist SOP
- Add client struct with conn and room fields
- Add broadcastMsg struct with room and data fields
- Change Hub.clients to Hub.rooms map[string]map[*websocket.Conn]bool
- Add Hub.connRoom map[*websocket.Conn]string for reverse lookup
- Change broadcast channel type to chan broadcastMsg
- Change register channel type to chan client
- Update New() to initialize rooms and connRoom maps
- Update ClientCount() to use len(h.connRoom)
- Add RoomCount() method
- Update Run() loop for room-segmented register/unregister/broadcast
- Update HandleWebSocket to extract room from query param
- Backward compatible: clients without ?room use default empty room
- Update TestNew to verify rooms and connRoom maps initialized
- Add TestRoomCount to verify initial room count is 0
- Fix TestBroadcastChannel to use broadcastMsg type
All existing unit and integration tests pass (16 hub tests + 21 other).
🤖 Assisted by the code-assist SOP
Add a 'logging' section to config.yaml supporting:
- output: stderr (default), stdout, or a file path
- level: debug, info, warn, error (default: info)
Implementation:
- New internal/logging package with Setup() for output destination
and Logger struct with level-aware Debug/Info/Warn/Error methods
- Config struct extended with Logging section (output + level fields)
- Hub refactored to accept *logging.Logger via constructor injection
- main.go initializes logging early after config load
The leveled logger suppresses messages below the configured threshold
while maintaining the stdlib log format. File output uses append mode
with 0644 permissions for safe log rotation.
🤖 Assisted by the code-assist SOP
- Fix metrics: change MessagesTotal, ConnectionsTotal, DisconnectionsTotal
from Gauge to Counter with proper _total naming convention
- Fix broadcast write-error handling: failed clients now get properly
removed with accurate metrics updates
- Add graceful shutdown: SIGINT/SIGTERM handling with 10s timeout,
CloseGoingAway frame sent to clients before disconnect
- Add integration tests: 11 tests using real WebSocket connections
covering connect, broadcast, disconnect, concurrency, and shutdown
- Fix example client port: changed from 8000 to 8443 to match config
- Rewrite README.md to reflect current features and usage
- Add AGENTS.md and .agents/summary/ documentation for AI assistants
